feat: Contextual Stream handling, Goroutine Leak Prevention #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
…in a `CloseChannel` method that returns a channel that will notify when the underlying connection is closed - whether it's on purpose or due to an error. Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
…in a `CloseChannel` method that returns a channel that will notify when the underlying connection is closed - whether it's on purpose or due to an error. Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
ShivanshVij
force-pushed
the
shiv/stream-wg
branch
from
0bd4214 to
d0f4da4
Compare
Signed-off-by: Shivansh Vij <shivanshvij@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 major changes.
First, it guarantees that shutting down the server will wait until all stream handler goroutines have exited. This is done using a mixture of stream context cancellation, and a waitgroup used specifically for streams.
Second, it extends the stream handler interfaces for all RPC streams to take in a context. This context will be cancelled if the client or server is shut down.
The main thing these two changes mean is that if the context passed into a stream handler is ever cancelled, we fully expect those handler goroutines to exit - otherwise they will block the exiting of the client or server.
This PR cannot be merged until loopholelabs/frisbee-go#179 is merged, and the
go.modis updated to point to the newly released version