Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reusable navbar template #966

Merged
merged 2 commits into from
Apr 17, 2020
Merged

reusable navbar template #966

merged 2 commits into from
Apr 17, 2020

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Apr 15, 2020

Before making changes to navbar, it's better to make it reusable so that we only need to change it in one file instead of multiple files. This PR contains:

  • adding navbar-template.html - navbar template that is extracted from other pages
  • modifying the *.html to use the template
  • updating the jquery library. The "slim" version won't work, so use the "min" version instead.

To test locally, you need to start the server (run npm start), instead of viewing it as a file because it has jQuery scripts.

Copy link
Contributor

@nabdelgadir nabdelgadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out locally, and it seems like it's no longer changing the colour for the page you're on.

See Getting Started is darker in the current one:

Screen Shot 2020-04-16 at 1 48 46 PM

Screen Shot 2020-04-16 at 1 49 31 PM

</ul>

</div>
</nav>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line here

@dhmlau dhmlau merged commit c7b2e82 into gh-pages Apr 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the slack branch April 17, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants