docs: add useDefaultIdType and generated to property properties #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agnes512, i think your commit message is too long (max 50 characters for the first line). Could you please fix it? Thanks. |
dhmlau
reviewed
Jan 8, 2020
| <td>No</td> | ||
| <td>Boolean</td> | ||
| <td> | ||
| <strong>For auto-migrate usage and the memory connector(id property only)</strong>. When it sets to <code>true</code>, the value of the property will be generated automatically with the default property type of the database. (e.g integer for MySQL and string for MongoDB) |
There was a problem hiding this comment.
Not knowing the actual behavior, I'm a bit confused on this line:
For auto-migrate usage and the memory connector(id property only)
Does it mean it only works for:
- auto-migrate
- for memory connector, it only works for id property. For other connectors, there's no such restriction?
There was a problem hiding this comment.
Reworded and removed memory-connector part.
agnes512
force-pushed
the
add-properties
branch
from
29304fa
to
e7edc3e
Compare
nabdelgadir
reviewed
Feb 1, 2020
agnes512
force-pushed
the
add-properties
branch
from
e7edc3e
to
ce5a8bf
Compare
agnes512
force-pushed
the
add-properties
branch
from
ce5a8bf
to
0bdd337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for property's property
useDefaultIdTypeadded in PR.Also add explanation for
generatedto help explainuseDefaultIdType.