move main pages from v4.loopback.io #840

dhmlau · 2019-05-28T20:35:29Z

Move the main pages from v4.loopback.io, so that the loopback.io will be showing the LB4 content.

User Experience

When user going to loopback.io, it shows the same content as v4.loopback.io. All the pages accessible from the navbar (at the top) will be the new LB4 content.

Docs at the nav bar will be pointing to /doc/lb4. The only way to get to LB3 documentation is either:
1. you go to the docs page and click LoopBack, that will bring you to the list of LB versions
2. at the footer > Documentation link will bring you to https://loopback.io/doc/ which shows all the versions.

After this PR has merged, we can redirect v4.loopback.io to loopback.io.

Discussion

@strongloop/loopback-maintainers, there are a few topics that I'd like to get your inputs:

Github stars shown on loopback.io
I've changed it to show the github star for loopback-next repo. As you might aware already, it's a much lower number. I think it makes sense to use the LB4 repo github star even though it's less impressive at this moment.
LoopBack 3 pages
For the following LB3 pages, I've "relocated" it to /lb3/* url.
i.e. loopback.io/getting-started -> loopback.io/lb3/getting-started
If we still want users to access those pages, I'd like to propose to have the banner at the top adding to say if you want to access the LoopBack 3 pages, go to /lb3/ link. But i'm not sure if it's necessary.

dhmlau · 2019-05-29T19:18:35Z

index-lb3.html

@@ -0,0 +1,202 @@
+---


rename it from index.html.

dhmlau · 2019-05-29T19:19:28Z

index.html

+
+    <!--Header alert -->
+    <div class="header-alert">
+        <p class="centered-regular">LoopBack 4 GA (General Availability) has been released in October 2018, read more in <a href="http://strongloop.com/strongblog/loopback-4-ga" target="_blank">the announcement post.</a> Click <a href="/lb3">here</a> for LoopBack 3 pages.</p>


I've edited the alert to show how to access the LB3 pages. Not sure if it's necessary.

b-admike

I am not too familiar with the changes, but from the demo you gave the team and the direction this PR is taking, LGTM. It makes sense to have the landing page of loopback.io point to the current release of our framework 💪.

nabdelgadir

Two things:

favicon is still the green one for the v4 pages
clicking on the LoopBack symbol on the green /lb3 pages leads back to the main lb4 page

Other than that LGTM 👍

dhmlau · 2019-05-30T17:19:52Z

favicon is still the green one for the v4 pages

It seems to be working for me, i.e. showing the LB4 logo as the favicon. Do you mind opening the browser in incognito mode to try it out again? Thanks.

clicking on the LoopBack symbol on the green /lb3 pages leads back to the main lb4 page

I think it makes sense to bring back to the main page loopback.io when clicking on the old LB logo?

nabdelgadir · 2019-05-30T17:29:57Z

@dhmlau

It seems to be working for me, i.e. showing the LB4 logo as the favicon. Do you mind opening the browser in incognito mode to try it out again? Thanks.

Tried it on Firefox and it's the right one 👍

I think it makes sense to bring back to the main page loopback.io when clicking on the old LB logo?

How would you go back to the main lb3 page? I'm fine with how it is now, but just wondering though.

dhmlau · 2019-05-30T17:35:53Z

I think it will go back to the same way how it brings you to the /lb3. An alternative is to put "LoopBack 3" in the navbar, which may not be a bad idea.
There was a comment about combining Resources and Docs, if that's the case, it can give us more room. let me try and post a screen cap.

dhmlau · 2019-05-30T17:40:11Z

@nabdelgadir, I think i like this one better.

Have LoopBack 3 in the navbar
Remove Docs from navbar
Alert: keep it only contains the GA blog.

WDYT?

nabdelgadir · 2019-05-30T17:44:49Z

@dhmlau LGTM 👍

dhmlau · 2019-05-30T18:03:24Z

@slnode test please

raymondfeng · 2019-05-30T20:40:20Z

@dhmlau Some quick feedback:

I still prefer to have both LB4 and LB3 showing on the landing page, similar as the current one.
Can we have Documentation a first class tab instead of hiding inside Resources
Can we show github stars for both lb4 and lb3?

raymondfeng · 2019-05-30T20:53:03Z

I see this error from the console:

[2019-05-30 13:39:05] ERROR `/lb3/images/overview/logo-collage.jpg' not found.

dhmlau · 2019-05-30T23:48:04Z

[2019-05-30 13:39:05] ERROR `/lb3/images/overview/logo-collage.jpg' not found.

I noticed that too. but couldn't find this jpg anywhere, I'll remove the reference of it to get rid of the error.

What about this now?

I've put back the Docs on the navbar
removed LoopBack3 and github star button from the navbar
Added the LB3 and LB4 button. The buttons look a bit weird but I can fix the padding around it if you're good with this design.

dhmlau · 2019-05-31T03:09:06Z

This is how it looks like now:

raymondfeng · 2019-05-31T06:07:06Z

I suggest that we get rid of LB4 GA banner. It’s not adding much value any more.

raymondfeng · 2019-05-31T06:08:08Z

What about a shortcut for blogs? We are good at publishing blogs and they are very useful information?

raymondfeng · 2019-05-31T17:34:15Z

@dhmlau The link for Docs is broken - http://127.0.0.1:4001/doc/en/lb.

css/loopback.css

dhmlau · 2019-05-31T20:04:00Z

Sorry about that @raymondfeng @nabdelgadir. I did some more testing and found more issues. :(
I think I've fixed them all. Once this PR is approved, I will squash the commit. Thanks.

dhmlau · 2019-06-03T20:39:12Z

@slnode test please

dhmlau mentioned this pull request May 29, 2019

add resource files for rework #842

Merged

dhmlau force-pushed the v4 branch 2 times, most recently from f380533 to ee58cc8 Compare May 29, 2019 19:17

dhmlau commented May 29, 2019

View reviewed changes

index-lb3.html

@@ -0,0 +1,202 @@

---

Copy link

Member Author

dhmlau May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename it from index.html.

dhmlau commented May 29, 2019

View reviewed changes

dhmlau marked this pull request as ready for review May 29, 2019 19:20

dhmlau requested a review from bschrammIBM as a code owner May 29, 2019 19:20

dhmlau requested a review from nabdelgadir May 30, 2019 02:40

b-admike approved these changes May 30, 2019

View reviewed changes

nabdelgadir approved these changes May 30, 2019

View reviewed changes

dhmlau force-pushed the v4 branch from fd9efd1 to bd648c7 Compare May 31, 2019 03:10

nabdelgadir reviewed May 31, 2019

View reviewed changes

css/loopback.css Outdated Show resolved Hide resolved

nabdelgadir approved these changes May 31, 2019

View reviewed changes

raymondfeng approved these changes Jun 3, 2019

View reviewed changes

dhmlau force-pushed the v4 branch from 0fcfc5c to 5d07d26 Compare June 3, 2019 20:28

move files from v4.loopback.io

5d07d26

dhmlau merged commit a18bbe9 into gh-pages Jun 3, 2019

delete-merged-branch bot deleted the v4 branch June 3, 2019 23:16

dhmlau mentioned this pull request Jun 4, 2019

[Proposal] Change main pages of loopback.io to use v4 pages #839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move main pages from v4.loopback.io #840

move main pages from v4.loopback.io #840

dhmlau commented May 28, 2019 •

edited

Loading

dhmlau May 29, 2019

dhmlau May 29, 2019

b-admike left a comment •

edited

Loading

nabdelgadir left a comment

dhmlau commented May 30, 2019

nabdelgadir commented May 30, 2019

dhmlau commented May 30, 2019

dhmlau commented May 30, 2019 •

edited

Loading

nabdelgadir commented May 30, 2019

dhmlau commented May 30, 2019

raymondfeng commented May 30, 2019 •

edited

Loading

raymondfeng commented May 30, 2019

dhmlau commented May 30, 2019

dhmlau commented May 31, 2019

raymondfeng commented May 31, 2019

raymondfeng commented May 31, 2019

raymondfeng commented May 31, 2019

dhmlau commented May 31, 2019

dhmlau commented Jun 3, 2019

move main pages from v4.loopback.io #840

move main pages from v4.loopback.io #840

Conversation

dhmlau commented May 28, 2019 • edited Loading

User Experience

Discussion

dhmlau May 29, 2019

Choose a reason for hiding this comment

dhmlau May 29, 2019

Choose a reason for hiding this comment

b-admike left a comment • edited Loading

Choose a reason for hiding this comment

nabdelgadir left a comment

Choose a reason for hiding this comment

dhmlau commented May 30, 2019

nabdelgadir commented May 30, 2019

dhmlau commented May 30, 2019

dhmlau commented May 30, 2019 • edited Loading

nabdelgadir commented May 30, 2019

dhmlau commented May 30, 2019

raymondfeng commented May 30, 2019 • edited Loading

raymondfeng commented May 30, 2019

dhmlau commented May 30, 2019

dhmlau commented May 31, 2019

raymondfeng commented May 31, 2019

raymondfeng commented May 31, 2019

raymondfeng commented May 31, 2019

dhmlau commented May 31, 2019

dhmlau commented Jun 3, 2019

dhmlau commented May 28, 2019 •

edited

Loading

b-admike left a comment •

edited

Loading

dhmlau commented May 30, 2019 •

edited

Loading

raymondfeng commented May 30, 2019 •

edited

Loading