Skip to content

cli: add a test suite for snapshot-matcher + improve debug logs#5803

Merged
bajtos merged 2 commits intomasterfrom
test/cli-snapshot-suite
Jun 22, 2020
Merged

cli: add a test suite for snapshot-matcher + improve debug logs#5803
bajtos merged 2 commits intomasterfrom
test/cli-snapshot-suite

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jun 22, 2020

  • add debug logs to snapshot-matcher to make it easier to troubleshoot snapshot-matcher related problems,
    especially when running the tests in parallel.
  • add a test suite with a shared test suite to verify snapshot-matcher's support for this advanced test organization. This scenario is tricky to get right when running tests in parallel.

Extracted from #5724

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

bajtos added 2 commits June 22, 2020 16:19
@bajtos
test(cli): add debug logs to snapshot-matcher
77a479b 
Make it easier to troubleshoot snapshot-matcher related problems,
especially when running the tests in parallel.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
test(cli): add a test suite for snapshot-matcher
b0d4fe1 
Add a test suite with a shared test suite to verify snapshot-matcher's
support for this advanced test organization. This scenario is tricky
to get right when running tests in parallel.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos added CLI Internal Tooling Issues related to our tooling and monorepo infrastructore labels Jun 22, 2020
@bajtos bajtos requested a review from raymondfeng June 22, 2020 14:57
@bajtos bajtos requested review from agnes512 and emonddr as code owners June 22, 2020 14:57
@bajtos bajtos self-assigned this Jun 22, 2020
@bajtos bajtos mentioned this pull request Jun 22, 2020
Closed
4 tasks
@bajtos bajtos merged commit b179414 into master Jun 22, 2020
@bajtos bajtos deleted the test/cli-snapshot-suite branch June 22, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@agnes512 agnes512 Awaiting requested review from agnes512

@emonddr emonddr Awaiting requested review from emonddr

Assignees

@bajtos bajtos

Labels

CLI Internal Tooling Issues related to our tooling and monorepo infrastructore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bajtos @raymondfeng