Conversation
agnes512
requested review from
deepakrkris,
emonddr,
hacksparrow and
nabdelgadir
as code owners
agnes512
commented
Apr 21, 2020
Contributor
Author
agnes512
left a comment
agnes512
left a comment
There was a problem hiding this comment.
added screenshots
|
|
||
| static get BASIC() { | ||
| return 'Empty Controller'; | ||
| return g.f('Empty Controller'); |
| ${chalk.yellow( | ||
| 'Please visit http://loopback.io/doc/en/lb4/Controller-generator.html for information on how models are discovered', | ||
| )}`, | ||
| chalk.yellow( |
Contributor
There was a problem hiding this comment.
Not sure if it matters but before only the "Please visit..." portion was in yellow and now all of it is
Contributor
Author
There was a problem hiding this comment.
agnes512
requested review from
dhmlau
and removed request for
deepakrkris,
emonddr,
hacksparrow and
nabdelgadir
dhmlau
approved these changes
Apr 21, 2020
nabdelgadir
approved these changes
Apr 21, 2020
| ${chalk.yellow( | ||
| 'Please visit http://loopback.io/doc/en/lb4/Controller-generator.html for information on how models are discovered', | ||
| )}`, | ||
| chalk.yellow( |
Contributor
There was a problem hiding this comment.
Not sure if it matters but before only the "Please visit..." portion was in yellow and now all of it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5130
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈