fix(http-server): ensure rejection handler is registered before the error event is emitted#5031
Merged
raymondfeng merged 1 commit intomasterfrom Apr 6, 2020
Merged
Conversation
…rror event is emitted
raymondfeng
requested review from
deepakrkris,
emonddr and
hacksparrow
as code owners
14 tasks
hacksparrow
approved these changes
Apr 6, 2020
bajtos
approved these changes
Apr 6, 2020
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
I don't fully comprehend the changes, but don't see any obvious problems and the CI is green, so LGTM 
raymondfeng
commented
Apr 6, 2020
| const req = httpGetAsync(server.url, agent); | ||
| // Wait until the request is accepted by the server | ||
| await pEvent(server.server, 'request'); | ||
| // Set up error handler for expected rejection before the event is emitted |
Contributor
Author
There was a problem hiding this comment.
Please note pEvent uses server.server.on('error', ...) behind the scene. We need to call it first so that an error handler is registered before the error event is emitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈