feat(cli): recognize PK properties defined as {id: 1}#4098
Merged
Conversation
bajtos
changed the title
{id: 1}{id: 1}
bajtos
force-pushed
the
fix/cli-relation-with-numeric-id-flag
branch
from
a7a5655 to
155ff36
Compare
3 tasks
raymondfeng
approved these changes
Nov 11, 2019
marioestradarosa
approved these changes
Nov 11, 2019
Refactor `ast-helper` used by `lb4 relation` to allow addition of
more patterns for detecting id property definitions.
Add support for PK properties defined as `{id: 1}`, in addition
to already supported flavor `{id: true}`.
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
fix/cli-relation-with-numeric-id-flag
branch
from
1c4856b to
e91230b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
ast-helperused bylb4 relationto allow addition of more patterns for detecting id property definitions.Add support for PK properties defined as
{id: 1}, in addition to already supported flavor{id: true}.Context
When importing models from LB3, or discovering them from a database, we set
idflag to a number - a position of the property in a multi-property index. This works fine at runtime, but was not supported by our CLI, as I discovered while writing migration guide for model relations (see #4058 and #3948).Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈