Improve tests for empty vs. default values#1707
Merged
Conversation
3 tasks
b-admike
approved these changes
Apr 9, 2019
Contributor
b-admike
left a comment
b-admike
left a comment
There was a problem hiding this comment.
LGTM, one minor comment.
| active: undefined, | ||
| }); | ||
| const found = await Player.upsertWithWhere({id: created.id}, {name: 'updated'}); | ||
| should(found.toObject().active).be.oneOf([ |
Contributor
There was a problem hiding this comment.
Should we want to preserve the checks for id and name as well?
Member
Author
There was a problem hiding this comment.
Those properties are not really affected by default values, I feel it's ok to not check them - we have other tests in place to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1705, I had to modify the tests added by #1704 to make them pass on different databases (SQL vs NoSQL, etc.)
This pull request is cherry-picking the changes from #1705 into master.
Related issues
Checklist
guide