Feature/refactor connector base #118
Conversation
1.5.1
Modify ValidationError constructor to include the model name and
a human-readable representation of the validation errors (messages)
in the error message.
Before this change, the message was pointing the reader
to `err.details`. Most frameworks (e.g. express, mocha) log only
`err.message` but not other error properties, thus the logs were
rather unhelpful.
Example of the new error message:
The `User` instance is not valid. Details: `name` can't be blank.
…ror-toString validations: include more details in `err.message`
v1.5.2
Remove remoting metadata
Remove references to Connector and BaseSQL, connectors should require() loopback-connector instead of loopback-datasource-juggler.
Add a shortcut for registering a new value type. The current implementation registers the type in the singleton registry `ModelBuilder.schemaTypes`. The API should allow us to to change the implementation to register the type in the scope of ModelBuilder instance only.
|
Test Failed. To trigger a build add comment - ".test\W+please" |
|
The build if failing because loopback-connector does not have a CI job yet and is not published to npmjs.org. @rmg Could you please create the CI job for loopback-connector? |
|
@bajtos I've added loopback-connector to CI, but it probably won't help much until its initial PR is merged into master. |
|
test please |
|
All is well |
|
Does this need to be rebased on master? The diff seems a bit large for what we are doing here. I see a ton of unrelated changes to docs. |
|
Rebased on top of 2.0, replaced |
Remove
ConnectorandBaseSQL, they were moved toloopback-connector.Add
ModelBuilder.prototype.defineValueTypethat should be used by connectors like loopback-connector-mysql to register new schema types.Requires loopbackio/loopback-connector#2.
/to @raymondfeng @ritch please review
strongloop/loopback#275