run shared tests from both v3 and v4 of juggler#180
Merged
nabdelgadir merged 1 commit intomasterfrom Jul 17, 2019
Merged
Conversation
nabdelgadir
force-pushed
the
build/test-juggler-v3-and-v4
branch
9 times, most recently
from
5f6afca to
b4c23f8
Compare
Contributor
Author
|
CI failure isn't related, but it's tracked in #183. |
b-admike
reviewed
Jul 16, 2019
Contributor
b-admike
left a comment
b-admike
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
package.json
Outdated
| "scripts": { | ||
| "lint": "eslint .", | ||
| "test": "mocha --UV_THREADPOOL_SIZE=100 --require test/init/init.js test/*.js", | ||
| "test": "mocha test/*.test.js node_modules/juggler-v3/test.js node_modules/juggler-v4/test.js", |
Contributor
There was a problem hiding this comment.
do we not need the UV_THREADPOOL_SIZE flag anymore?
Contributor
Author
There was a problem hiding this comment.
Let me add it back; I removed it by accident. Thanks!
nabdelgadir
force-pushed
the
build/test-juggler-v3-and-v4
branch
from
b4c23f8 to
88e91e4
Compare
b-admike
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run shared tests from juggler v3 and v4.
Related issues
Checklist