Skip to content

Update to use G7SensorKit PR 34 instead of PR 33 for G7 issues #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

marionbarker
Copy link
Contributor

Instead of using G7SensorKit PR 33 as a potential fix for the G7 loss of connectivity that some people are experiencing, switch to using G7SensorKit PR 34.

As usual,

  • when building with Xcode, this new version will offer an update to the old version (if one is already applied)
  • when building with Browser Build or using Xcode when no patch was applied, the new version is applied

To test with Xcode (before this PR is merged):

export PATCH_BRANCH=update_g7_fix
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"

@marionbarker marionbarker requested a review from bjorkert March 22, 2025 18:00
Copy link
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code review, applying the customization to main and successful build.

@marionbarker marionbarker merged commit b56380c into dev Mar 22, 2025
@marionbarker marionbarker deleted the update_g7_fix branch March 22, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants