Display charging indicator #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionbarker
approved these changes
Apr 16, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Code Review
Approve from code review
Test
Look at the battery row in the Information Display on LoopFollow phone
- Observe charging indicator is displayed when Trio phone is plugged in
- Observe charging indicator is not displayed when Trio phone is not plugged in
|
Hi team, is this only for Trio 1.0? I’m using Trio 0.2.4 and the latest dev branch of LoopFollow, however the charging symbol doesn’t appear, even after waiting for multiple updates. Otherwise, is there anything else I could help doing wrong? |
Contributor
Author
|
Hi, This feature is for the next version of Trio, not available in 0.2.x. We might also release a customization/PR for Loop to get the functionality in there as well. BR/Jonas |
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an charging indicator for when the looping phone is charging. This has been tested with Trio, this feature could be included in Loop in the future as well.
Thanks to @dsnallfot for informing me that this information is available in Trio device status.