Filter out cal entries #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionbarker
approved these changes
Sep 24, 2024
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Tested with a URL that had "cal" type (for Libre).
Did not update with main.
Nominal behavior with filter_out_cal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to filter out cal type entries from the bg result from Nightscout.
These entries would stop the bg value to be visible until they are out of scope for the fetch of data from Nightscout.
Preferably we should in the code filter out any type we don't want to use but this is what I have bandwidth to do right now.