Implement Display of Manual BG Values and Standardize Unit Conversion #288
+40
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code review looks good with possible suggestion to later modify the capitalization for some variables: in the US it is mg/dL not mg/Dl. The actual name is not that important, so merging as is. Confirmed that units display as expected and manual glucose entry (from NS careportal) shows up on LoopFollow display. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the display of manual BG values from Loop and Apple Health in the app's graphs. It also ensures that manual BG check entries from Nightscout using mmol are correctly shown. Additionally, the PR standardizes mmol/L <-> mg/dL conversions throughout the application using centralized constants for improved consistency and maintainability.