Skip to content

Conversation

@bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Jul 26, 2023

Preparation for multi app using xcode and browser build.

app_suffix and display_name will be set in the config file for the second and third repo.
app_suffix will be Two and Three while display_name is ment to be set by the end user

This should work well for both xcode users (we could add these options in the buildselect script) as well as browser build.

@bjorkert bjorkert requested review from dnzxy and marionbarker July 26, 2023 20:20
@bjorkert bjorkert changed the base branch from Main to dev July 26, 2023 20:20
@bjorkert bjorkert marked this pull request as draft July 28, 2023 18:52
@bjorkert
Copy link
Contributor Author

Putting this on hold, I want to synchronize how bundle_id is set with how we do it for the browser build, so an Xcode build can replace a browser build and vice versa.

@bjorkert bjorkert marked this pull request as ready for review July 30, 2023 09:37
@bjorkert bjorkert marked this pull request as draft August 26, 2023 20:38
@fzzarf220
Copy link

Was the issue ever resolved? Having ability for multiple loopers would be quite beneficial!!

@bjorkert
Copy link
Contributor Author

Was the issue ever resolved? Having ability for multiple loopers would be quite beneficial!!

It is still in draft. As it is, it is working fine for Mac-Xcode build but I also want it to cover Browser-Build, thats what delaying it.

@fzzarf220
Copy link

Was the issue ever resolved? Having ability for multiple loopers would be quite beneficial!!

It is still in draft. As it is, it is working fine for Mac-Xcode build but I also want it to cover Browser-Build, thats what delaying it.

I wait impatiently :)

One thing that would also make this great for browser builds, if we could use Env Variables instead of touching source. This way no file has to change, just variables set at build time. Not sure how that could be done, but that would also be powerful! Just a thought.

@bjorkert bjorkert marked this pull request as ready for review November 25, 2023 20:13
@bjorkert bjorkert merged commit e055c0d into dev Nov 27, 2023
@bjorkert bjorkert deleted the multiple-loopers branch November 27, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants