Skip to content

Fix calibration decoding, and lagged backfill processing #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

marionbarker
Copy link

@marionbarker marionbarker commented Apr 27, 2025

Purpose

Update the G7SensorKit loopandlearn fork, trio branch to include the bugfix changes made by LoopKit / G7SensorKit PR 35 to "Fix calibration decoding, and lagged backfill processing"

Method

PR 35 consisted of a single commit, so use cherry-pick to apply to this PR branch:

git switch trio
git pull
git switch -c update_for_pr35
git cherry-pick 5481bd0014ff09ccaa4cd52c60581b279389fd38

Confirm that this branch has only the expected code differences with respect to the main branch (which is kept up to date with LoopKit main branch.)

Expected code differences

After this merge, expected differences between LoopKit / G7SensorKit main and loopandlearn / G7SensorKit trio:

  • Default for glucose upload: the trio branch defaults G7 upload to enabled whereas LoopKit has it disabled
  • PR 32 to add build dependency is not yet merged into LoopKit but is merged into loopandlearn / G7SensorKit trio

@marionbarker marionbarker requested review from bjorkert and dnzxy April 27, 2025 19:53
Copy link

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by code review and confirming that the change is identical to LoopKit#35

@marionbarker marionbarker merged commit 7a9341c into trio May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants