Open
Conversation
enlight
requested changes
Mar 26, 2019
Makefile
Outdated
| github.com/loomnetwork/weave-blueprint/src \ | ||
| gopkg.in/check.v1 | ||
| cd $(GO_ETHEREUM_DIR) && git checkout master && git pull && git checkout $(ETHEREUM_GIT_REV) | ||
| cd $(SRC_DIR) && git checkout split-main && git pull origin split-main |
Contributor
There was a problem hiding this comment.
This doesn't make sense to me, why would you go get the current package, and also check it out?
Author
There was a problem hiding this comment.
I think this is tempory so the plugin can be exported. For this, we need the split-main branch built rather than the main one.so it plays nice with loomchian.
split-main moves the contract out of the main package into the blueprint package so it can be exported.
After split-main has been merged into master for the first time, then this line #79 can be removed.
enlight
force-pushed
the
split-main
branch
2 times, most recently
from
0549f7d to
7b55ff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.