Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant group permissions db lookup #530

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Removed redundant group permissions db lookup #530

merged 4 commits into from
Jul 12, 2022

Conversation

manageruz
Copy link
Collaborator

Added test GetPermissionsForUser.

@manageruz manageruz requested a review from MGatner June 29, 2022 14:16
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll have to dig into why tests are failing, probably unrelated.

@manageruz
Copy link
Collaborator Author

manageruz commented Jun 30, 2022

Yes, it would be great if you can have a look to failing tests. Thank you.

fix coding standards
fix coding standards error
fix coding standards
@MGatner
Copy link
Collaborator

MGatner commented Jul 12, 2022

I'm going to merge this then adjust for tests as needed.

@MGatner MGatner merged commit c7bce0b into lonnieezell:develop Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Myth\Auth\Authorization\PermissionModel:doesUserHavePermission() - Why Check group permissions?
2 participants