Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix namespace entity ci 4.1.9 #514

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

agiltriyas
Copy link
Contributor

Namespace CodeIgniter/entity in ci version 4.1.9 is deprecated. change into codeIgniter/entity/entity

Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a number of style changes were scooped up in here too - this library is probably due for a DevKit update and a complete run through the tools.

@MGatner MGatner merged commit f78c2fa into lonnieezell:develop Apr 27, 2022
@lonnieezell
Copy link
Owner

I started to look at this one last night and one issue is that it now requires PHP 7.4 instead of 7.3, so the matrix needs to be updated - and something needs to be noted on minimum version changes.

@lonnieezell
Copy link
Owner

I wonder if we should revert this, get other stuff merged that needs to be, do a new release that still works for older versions of CI, and then do a new release right on the heels of that with this change and the updated PHP/CI version requirement?

@MGatner
Copy link
Collaborator

MGatner commented Apr 27, 2022

It's up to you. Our last release was July 2, 2021. Composer will handle version minimums, so we don't need a new major version to do a release for >= 7.4. Up to this point the dev dependency has been codeigniter4/codeigniter4 which means we have no idea if the develop branch for this package is still backwards-compatible to 4.1.9.

I am working on switching this to DevKit right now, which necessitates >= 7.4. We can always merge master up to right before this commit and put our a release, though honestly with workflows failing for the last many months I can't vouch for the state of any given commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants