Remove name field
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should a note be added to the docs about this, do you think? |
|
Would that be for existing users? Or something to the extent of "you'll want to add your own identifying info" + examples? |
|
Was thinking something closer to your second option there. |
|
Something like that? |
|
Yup. I think that works for now. Thanks! |
|
Maybe should merit it's own file eventually, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #44 it is preferable to leave off any unnecessary identity information so developers can use their own fields. Since
nameisn't currently in use this removes it form migrations, model, controller stub reference, and tests.