Using a `type` of `SimpleSchema.oneOf` prevents `custom` function from being called

[nidem]

This code will call the custom function:

value:
    label: 'Value'
    type: String
    custom: ->
        console.log 'in custom'
        console.log this
        return undefined

This will not:

value:
    label: 'Value'
    type: SimpleSchema.oneOf(String, Boolean)
    custom: ->
        console.log 'in custom'
        console.log this
        return undefined

Edit: Original written in CoffeeScript, but easy to convert

value: {
    label: 'Value',
    type: TRY_STRING_OR_ONEOF,
    custom: function () {
        // This runs when type == String, but not when SimpleScheme.oneOf
        console.log('in custom')
        console.log(this)
        return undefined
    }
}

[aldeed]

@nidem I believe custom is supposed to be a type-specific option. So it would be:

value: {
    label: 'Value',
    type: SimpleSchema.oneOf({
      type: String,
      custom: yourStringCustomFunction,
    }, {
      type: Boolean,
      custom: yourBoolCustomFunction,
    })
}

I need to update the docs to better explain which options are type-specific in a oneOf situation.

[nidem]

I tried that but it doesn't seem to call the correct function. Maybe this is a bug then?

value:
		label: 'Value'
		type: SimpleSchema.oneOf
			type: String,
			custom: ->
				console.log 'custom string validation'
		,
			type: SimpleSchema.Integer
			custom: ->
				console.log 'custom integer validation'
		,
			type: Boolean
			custom: ->
				console.log 'custom boolean validation'

Via browser javascript console:

Settings.update({_id: '4fj4NFLRWzBhDezBm'}, {$set: {value: false }})
settings.coffee:60 custom string validation

[nidem]

CoffeeScript -> JavaScript

value: {
      label: 'Value',
      type: SimpleSchema.oneOf({
        type: String,
        custom: function() {
          return console.log('custom string validation');
        }
      }, {
        type: SimpleSchema.Integer,
        custom: function() {
          return console.log('custom integer validation');
        }
      }, {
        type: Boolean,
        custom: function() {
          return console.log('custom boolean validation');
        }
      })
    }

[github-actions]

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

If this makes you happy, please consider becoming a sponsor.

Your semantic-release bot 📦🚀