Show modal to alert users the unsaved change in general settings page #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
force-pushed
the
general_setting_7497
branch
from
0fb2e4e
to
16db32e
Compare
|
We can consider using Tab to group |
a110605
requested review from
FrankYang0529 and
innobead
and removed request for
FrankYang0529
a110605
changed the title
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
a110605
force-pushed
the
general_setting_7497
branch
from
16db32e
to
9b2bc19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current general settings page are too long that users easily forget to "save" the settings change before leaving this page.
This PR
issus : longhorn/longhorn#7497
after.mov