Display AutoEvicting on Node tab while auto evicting

[ejweber]

longhorn/longhorn#2238

I originally considered also making AutoEvicting be a separate status from Unschedulable on the Dashboard, but this was too granular of a distinction in my opinion (and the opinion of a couple others I talked to). A user will probably only have one (or a small number) of auto evicting nodes at a time, and the Node tab is a good place to quickly identify it/them.

[ejweber]

As part of this PR, I reworked a few comments that I previously found confusing.

[votdev]

Testing is currently blocked because of conflicts in longhorn/longhorn-manager#2138.

[ejweber]

Testing is currently blocked because of conflicts in longhorn/longhorn-manager#2138.

Conflicts are resolved for now, but I think it is fine to wait until those changes are actually in master to review this one. I can ping you when it is appropriate @votdev.

[ejweber]

This one should be testable with components off of the master branches now @votdev.

[m-ildefons]

I attempted to test this, by deploying a build of the current master branch of the longhorn manager using the master branch of the chart. However I found that the drained node is displayed as "unschedulable" rather than "auto evicting" both during eviction and after.
In addition to that, I noticed that the display color of the "unschedulable" status is grey for the disk and yellow for the node.
Am I possibly doing something wrong during testing this?

longhorn-auto-evict.mp4

[ejweber]

It took me a minute, but I recognized the problem, @m-ildefons. You don't actually have any replicas scheduled to your nodes in the attached video. We only display AutoEvicting as long as we are actively evicting replicas. Once we are done, we revert back to Unschedulable.

See https://github.com/longhorn/longhorn/blob/6ad473c1b68da13da8337489eefcc5cab26dd891/enhancements/20230905-automatically-evict-replicas-while-draining.md?plain=1#L203-L221 for a complete test case that will demonstrate the new UI behavior.

[ejweber]

In addition to that, I noticed that the display color of the "unschedulable" status is grey for the disk and yellow for the node.

This is not a regression, though I'm not sure whether or not it was originally intended. In https://github.com/longhorn/longhorn-ui/pull/270/files, @smallteeths added:

longhorn-ui/src/routes/host/DiskList.js

Lines 16 to 18 in 3b15475

	if (node.conditions && node.conditions.Schedulable && node.conditions.Schedulable.status && node.conditions.Schedulable.status.toLowerCase() === 'false') {
	return (<span className="disabled">Unschedulable</span>)
	}

While it sets the text to Unschedulable under these circumstances, it uses the disabled className, causing the gray text.

There is no discussion of this in that PR. I will go ahead and fix it to be yellow unless you disagree?

[ejweber]

Welcome to the team @scures! Could you review this one when you get a chance?

[votdev]

LGTM

[ejweber]

@longhorn/dev-ui

We need to get this one merged if possible so we can transition longhorn/longhorn#2238 to Ready For Testing for the upcoming v1.6.0 release.

[innobead]

LGTM

[ejweber]

@mergify backport v1.5.x

[mergify]

backport v1.5.x

✅ Backports have been created

• #679 Display AutoEvicting on Node tab while auto evicting (backport #663) has been created for branch v1.5.x