Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(robot): migrate test_backing_image_basic_operation #1867

Merged
merged 1 commit into from
May 3, 2024

Conversation

yangchiu
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8259

What this PR does / why we need it:

migrate test_backing_image_basic_operation

Special notes for your reviewer:

Additional documentation or context

@yangchiu yangchiu requested a review from a team April 23, 2024 07:17
@yangchiu yangchiu self-assigned this Apr 23, 2024
Copy link
Collaborator

@khushboo-rancher khushboo-rancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. couple of minor things

Verify all disk file status of backing image ${backing_image_name} are ready
all_disk_file_status_are_ready ${backing_image_name}

Verify try to clean up backing image ${backing_image_name} from a disk will fail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Verify clean up backing image ${backing_image_name} from a disk will fail :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refined. Thank you!

Verify try to clean up backing image ${backing_image_name} from a disk will fail
Run Keyword And Expect Error * clean_up_backing_image_from_a_random_disk ${backing_image_name}

Verify try to delete backing image ${backing_image_name} will fail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Verify delete backing image ${backing_image_name} will fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refined. Thank you!

Verify try to delete backing image ${backing_image_name} will fail
Run Keyword And Expect Error * delete_backing_image ${backing_image_name}

Clean up backing image ${backing_image_name} from a disk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but can we clean up from desired disk if we know node name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's possible. We can retrieve the node to know the uuid of the disk, and then clean up the backing image by uuid.

But maybe it's not required at this moment, since the test case is testing the cleaning up API works or not, specifying a node add no extra information to it.

@@ -10,9 +10,10 @@ Create volume ${volume_id}
${volume_name} = generate_name_with_suffix volume ${volume_id}
create_volume ${volume_name} 2 3

Create volume ${volume_id} with frontend ${frontend_name}
Create volume ${volume_id} with
[Arguments] &{config}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

mergify bot commented Apr 29, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

Copy link

mergify bot commented May 2, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

@chriscchien chriscchien self-requested a review May 3, 2024 11:12
chriscchien
chriscchien previously approved these changes May 3, 2024
Copy link
Contributor

@chriscchien chriscchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, went through the code and did not have any concern.

Copy link

mergify bot commented May 3, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

Signed-off-by: Yang Chiu <yang.chiu@suse.com>
@yangchiu yangchiu merged commit 6e3e381 into longhorn:master May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants