Fix test_disk_eviction_with_node_level_soft_anti_affinity_disabled #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 7210 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
7210-eviction-test-failures
branch
from
ce4076e
to
2cfdaf6
Compare
khushboo-rancher
approved these changes
Nov 30, 2023
This was referenced Dec 5, 2023
|
I initially requested @roger-ryao's review because he raised the associated issue. I am fine with merging based on @khushboo-rancher's review if that's more convenient, however. |
|
@mergify backport v1.5.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#7210
The node controller refuses to update a node until its disk monitor has synced. In v1.6.0, the node controller is responsible for triggering replica eviction. This means it may take longer for replica eviction to start than it did in the past. In the long term, we may want to try to tighten up this timing again, but unfortunately, there is no obvious and easy way to do so.
test_disk_eviction_with_node_level_soft_anti_affinity_disabled is currently failing because it does not wait long enough for a replica to be evicted from one disk before checking for it on another. This PR ensures the eviction process has started before proceeding to do the check.