Refactor restoration tests with replica failure and add one #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport v1.5.x |
✅ Backports have been created
|
Longhorn 6905 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
6905-test-unschedulable-replica-restoration
branch
from
c0eca87
to
f10abdb
Compare
This test case actually depends on longhorn/longhorn-manager#1928, which went into v1.5.0. We cannot backport it to v1.4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#6905
The behavior requested in longhorn/longhorn#2103 was already added with the inclusion of the allow-volume-creation-with-degraded-availability setting. This PR adds a test with that setting on and confirms volume restoration completes. Because it is so similar to a couple of other tests, it refactors all three tests to use the same base functionality.
We should theoretically be able to backport all the way to v1.4.x, since the setting has been around that long. Haven't confirmed yet.