Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't log NodeReady is true and false in same reconcile loop #3112

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: don't log NodeReady is true and false in same reconcile loop #3112

merged 3 commits into from
Sep 4, 2024

Conversation

ejweber
Copy link
Contributor

@ejweber ejweber commented Aug 27, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#7738

What this PR does / why we need it:

Key change:

  • A defer statement and a nodeReady conditional variable now ensure we don't record ready (i.e. log and emit an event) during the check for a manager pod just to later record not ready during the Kubernetes node status check.

Additional changes:

  • A nil pointer exception used to be possible in this controller, though the severity and potential to hit it was extremely low. (It probably required a longhorn-manager pod running on a node that was actively being removed from the cluster. In this situation, a crash is probably fine.) The exception should no longer be possible.
  • The logic for setting Ready and Schedulable is now broken out into a separate function.

@ejweber
Copy link
Contributor Author

ejweber commented Aug 27, 2024 •
edited
Loading

Before:

  1. Install Longhorn.
  2. Watch longhorn-manager logs.
  3. SSH to a Longhorn node.
  4. Stop kubelet.
  5. Wait for confusing logs that show Ready fluctuate between true and false (after about thirty seconds).
root@eweber-v126-worker-9c1451b4-6464j:~# systemctl stop k3s-agent

eweber@laptop:~/longhorn> kubetail -n longhorn-system -l app=longhorn-manager | grep Ready
[longhorn-manager-7dp4j longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617346\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-bth5g longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617346\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-7dp4j longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617346\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-7dp4j longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617771\", FieldPath:\"\"}): type: 'Normal' reason: 'Ready' Node eweber-v126-worker-9c1451b4-6464j is ready" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-7dp4j longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617771\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-bth5g longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617771\", FieldPath:\"\"}): type: 'Normal' reason: 'Ready' Node eweber-v126-worker-9c1451b4-6464j is ready" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-bth5g longhorn-manager] time="2024-08-26T22:05:40Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145617771\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"

After:

  1. Install Longhorn.
  2. Watch longhorn-manager logs.
  3. SSH to a Longhorn node.
  4. Stop kubelet.
  5. Only see logs that show Ready go to false (after about thirty seconds).
  6. Start kubelet.
  7. Verify the Longhorn node shows ready again.
root@eweber-v126-worker-9c1451b4-6464j:~# systemctl stop k3s-agent

eweber@laptop:~/longhorn> kubetail -n longhorn-system -l app=longhorn-manager | grep Ready
[longhorn-manager-88hwg longhorn-manager] time="2024-08-27T15:23:03Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145933310\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"
[longhorn-manager-k2lpp longhorn-manager] time="2024-08-27T15:23:03Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"eweber-v126-worker-9c1451b4-6464j\", UID:\"04801ad4-91bb-480b-94e4-86638500369d\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"145933310\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node eweber-v126-worker-9c1451b4-6464j not ready: NodeStatusUnknown" func="record.(*eventBroadcasterImpl).StartLogging.func1" file="event.go:377"

@ejweber ejweber mentioned this pull request Aug 27, 2024
Closed
@ejweber ejweber force-pushed the 7738-contradicting-logs branch 2 times, most recently from ff269c4 to cd1e1d9 Compare August 27, 2024 15:57
james-munson
james-munson previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@james-munson james-munson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has bugged me in RWX HA testing, too. Glad to see it addressed. LGTM.
(I assume that when kubelet is restored, or the node restarts, it does return to Ready.)

@ejweber
Copy link
Contributor Author

ejweber commented Aug 29, 2024 •
edited
Loading

It looks like the CI failure is legitimate. I will investigate.

It looks like the CI failure is a result of expecting the duplicate logging. I am reworking the tests slightly.

@ejweber
Copy link
Contributor Author

ejweber commented Aug 29, 2024

(I assume that when kubelet is restored, or the node restarts, it does return to Ready.)

I does, but it is good to add this to the test plan above. I will do that.

james-munson
james-munson previously approved these changes Aug 29, 2024
View reviewed changes
derekbit
derekbit previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Show resolved Hide resolved
@ejweber ejweber marked this pull request as draft September 3, 2024 20:09
@ejweber ejweber dismissed stale reviews from derekbit and james-munson via b845eeb September 3, 2024 20:09
@ejweber
fix: don't log NodeReady is true and false in same reconcile loop
2b50fed 
Longhorn 7738

Signed-off-by: Eric Weber <eric.weber@suse.com>
@ejweber
test: integration tests no longer expect duplicate log
dfa50c0 
Longhorn 7738

Signed-off-by: Eric Weber <eric.weber@suse.com>
@ejweber
refactor: abstract node controller ready and schedulable code
f7ace75 
Longhorn 7738

Signed-off-by: Eric Weber <eric.weber@suse.com>
@ejweber ejweber marked this pull request as ready for review September 3, 2024 21:34
derekbit
derekbit approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 9ab53c8 into longhorn:master Sep 4, 2024
8 checks passed
@ejweber
Copy link
Contributor Author

ejweber commented Sep 4, 2024

@mergify backport v1.7.x v1.6.x

@mergify Mergify
Copy link

mergify bot commented Sep 4, 2024 •
edited
Loading

backport v1.7.x v1.6.x

✅ Backports have been created

This was referenced Sep 4, 2024
Merged
Merged
This was referenced Sep 4, 2024
Closed
Closed
This was referenced Oct 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@james-munson james-munson james-munson left review comments

Assignees

@ejweber ejweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejweber @derekbit @james-munson