Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): DR volume #3035

Merged
merged 3 commits into from
Aug 28, 2024
Merged

feat(v2): DR volume #3035

merged 3 commits into from
Aug 28, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6613

What this PR does / why we need it:

Remove DR volume blocking in webhook.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Jul 31, 2024
Copy link

mergify bot commented Jul 31, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 4 times, most recently from 76b7083 to 5a0b7a5 Compare August 2, 2024 03:10
Copy link

mergify bot commented Aug 3, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 8 times, most recently from be38d5c to 36e3101 Compare August 12, 2024 07:27
@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 5 times, most recently from 534a158 to 642d60b Compare August 16, 2024 03:18
Copy link

mergify bot commented Aug 17, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang marked this pull request as ready for review August 20, 2024 09:37
@c3y1huang c3y1huang requested review from derekbit and a team August 20, 2024 09:38
@c3y1huang c3y1huang marked this pull request as draft August 22, 2024 03:35
Copy link

mergify bot commented Aug 22, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang marked this pull request as ready for review August 23, 2024 06:44
Copy link

mergify bot commented Aug 24, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

Copy link

mergify bot commented Aug 26, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume branch 2 times, most recently from 8d58a90 to 955c31c Compare August 28, 2024 02:59
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit c99b453 into longhorn:master Aug 28, 2024
8 checks passed
@c3y1huang c3y1huang deleted the feat-v2-dr-volume branch August 28, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants