-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add recurring job label to backup metrics or empty value #3034
feat(metrics): Add recurring job label to backup metrics or empty value #3034
Conversation
97b9a4a
to
43e9650
Compare
43e9650
to
b539978
Compare
cc @ChanYiLin @c3y1huang for helping review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should also update the document. @YvanGuidoin could you help? Thank you. |
@c3y1huang I can help end of next week as I am currently travelling |
Signed-off-by: Yvan <y.guidoin@meteocontrol.com>
b539978
to
cb3d1a9
Compare
@YvanGuidoin I've created a feature request for this. In the future, I encourage you to create it yourself next time to have it included in the development cycle. Thank you. cc @derekbit |
cc @ChanYiLin |
Hi @YvanGuidoin Some enhancement features or function changing features may need to design an e2e test in longhorn-test repo, but there is no need for this one. |
Which issue(s) this PR fixes:
Issue N/A
What this PR does / why we need it:
Monitoring on usage of Backup per recurring job so we can trace the type of backup applied by PVC
Special notes for your reviewer:
Tried to understand documentation here and on longhorn-tests, but I am thoroughly confused on how to test a simple code change without creating a new version.
make
/make test
and CI seems to work though.Additional documentation or context
Our recurring jobs, to trace usage/granularity per PVC, so we can raise alarms on certain pods not being backed up enough etc...