Fix a race condition in volumeattachment controller #2627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race condition is that we sometimes mark the volumeattachment ticket as satisfied even though the volume has empty spec.NodeID and has started detaching process. longhorn-7937 Signed-off-by: Phan Le <phan.le@suse.com>
|
Sorry @c3y1huang @mantissahz could either of you help to give this one a test run to see if the issue still exists: I have to log out a bit |
|
|
Closing this PR as we are proposing a new approach (#2635) to replace this approach. Could you take a look @c3y1huang @mantissahz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race condition is that we sometimes mark the volumeattachment ticket as satisfied even though the volume has empty spec.NodeID and has started the detaching process.
More context is at longhorn/longhorn#7937 (comment)
longhorn/longhorn#7937