Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add pvc namespace to volume metrics (backport #2284) #2290

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat(metrics): add pvc namespace to volume metrics (backport #2284) #2290

merged 2 commits into from
Nov 13, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 13, 2023

This is an automatic backport of pull request #2284 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

antoninferrand and others added 2 commits November 13, 2023 07:00
@antoninferrand @mergify
feat(metrics): add pvc namespace to volume metrics
ee44951 
Signed-off-by: Antonin Ferrand <antonin.ferrand3@gmail.com>
(cherry picked from commit c83e101)
@mantissahz @mergify
fix(metric): Modify pvc namespace label name
761e3e0 
The label `namespace` will be used by the Prometheus collector.
Change it to `pvc_namespace`

Signed-off-by: James Lu <jamesluhz@gmail.com>
(cherry picked from commit b5e478d)
@mergify mergify bot mentioned this pull request Nov 13, 2023
Merged
@innobead innobead enabled auto-merge (rebase) November 13, 2023 07:02
@mantissahz
Copy link
Contributor

related: longhorn/longhorn#7077

@innobead innobead merged commit 35b1637 into v1.4.x Nov 13, 2023
5 checks passed
@innobead innobead deleted the mergify/bp/v1.4.x/pr-2284 branch November 13, 2023 07:12
@mantissahz mantissahz mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantissahz @innobead @antoninferrand