Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource not found error #2281

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix resource not found error #2281

merged 1 commit into from
Nov 6, 2023

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Nov 5, 2023

  1. Get the secret/configmap directly from API server if it is not in longhorn-system namespace.
  2. PriorityClass is non-namespaces, so moving it to KubeInformerFactory is much clear.

longhorn/longhorn#7045

@derekbit derekbit requested a review from a team as a code owner November 5, 2023 18:01
1. Get the secret/config directly from API server instead of relying on caches if it is not in longhorn-system namespace.

2. PriorityClass is non-namespaces, so moving it to KubeInformerFactory is much clear.

Longhorn 7045

Signed-off-by: Derek Su <derek.su@suse.com>
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@innobead innobead merged commit 43e3309 into longhorn:master Nov 6, 2023
5 checks passed
@innobead
Copy link
Member

innobead commented Nov 6, 2023

@mergify backport v1.5.x

Copy link

mergify bot commented Nov 6, 2023

backport v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants