fix(backup): backupInfo might be nil

The backupInfo would be nil when we try to pull the backups from remote backup target. Ref: 6998 Signed-off-by: James Lu <james.lu@suse.com>
longhorn · Oct 31, 2023 · b810121 · b810121
1 parent d046b13
commit b810121
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/controller/backup_volume_controller.go b/controller/backup_volume_controller.go
@@ -323,8 +323,10 @@ func (bvc *BackupVolumeController) reconcile(backupVolumeName string) (err error
 				"backupvolume": backupVolumeName,
 				"backuptarget": backupURL}).Warn("Failed to get backupInfo from remote backup target")
 		} else {
-			if accessMode, exist := backupInfo.Labels[types.GetLonghornLabelKey(types.LonghornLabelVolumeAccessMode)]; exist {
-				backupLabelMap[types.GetLonghornLabelKey(types.LonghornLabelVolumeAccessMode)] = accessMode
+			if backupInfo != nil && backupInfo.Labels != nil {
+				if accessMode, exist := backupInfo.Labels[types.GetLonghornLabelKey(types.LonghornLabelVolumeAccessMode)]; exist {
+					backupLabelMap[types.GetLonghornLabelKey(types.LonghornLabelVolumeAccessMode)] = accessMode
+				}
 			}
 		}