Do not support reserved storage for block-type disks

Longhorn 7234 Signed-off-by: Derek Su <derek.su@suse.com>
longhorn · Dec 1, 2023 · 7a0c3ed · 7a0c3ed
1 parent e33e38d
commit 7a0c3ed
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/webhook/resources/node/validator.go b/webhook/resources/node/validator.go
@@ -61,6 +61,12 @@ func (n *nodeValidator) Create(request *admission.Request, newObj runtime.Object
 				return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported since v2 data engine is disabled", name, disk.Type), "")
 			}
 		}
+
+		if disk.Type == longhorn.DiskTypeBlock {
+			if disk.StorageReserved != 0 {
+				return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported to reserve storage", name, disk.Type), "")
+			}
+		}
 	}
 
 	return nil
@@ -148,6 +154,11 @@ func (n *nodeValidator) Update(request *admission.Request, oldObj runtime.Object
 					newNode.Name, name, disk.Path), "")
 			}
 		}
+		if disk.Type == longhorn.DiskTypeBlock {
+			if disk.StorageReserved != 0 {
+				return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported to reserve storage", name, disk.Type), "")
+			}
+		}
 	}
 
 	// Validate delete disks