Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add snapshot max count and size #286

Merged
merged 3 commits into from
Jan 3, 2024
Merged

feat: add snapshot max count and size #286

merged 3 commits into from
Jan 3, 2024

Conversation

FrankYang0529
Copy link
Contributor

@FrankYang0529 FrankYang0529 commented Sep 15, 2023 •
edited
Loading

@FrankYang0529 FrankYang0529 mentioned this pull request Sep 15, 2023
Merged
@FrankYang0529 FrankYang0529 marked this pull request as ready for review September 15, 2023 09:36
@FrankYang0529 FrankYang0529 requested a review from a team as a code owner September 15, 2023 09:36
@FrankYang0529 FrankYang0529 mentioned this pull request Sep 15, 2023
Closed
@FrankYang0529 FrankYang0529 self-assigned this Sep 19, 2023
@longhorn longhorn deleted a comment from mergify bot Dec 11, 2023
@longhorn longhorn deleted a comment from mergify bot Dec 11, 2023
@longhorn longhorn deleted a comment from mergify bot Dec 11, 2023
@longhorn longhorn deleted a comment from mergify bot Dec 12, 2023
innobead
innobead previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Waiting for engine PR merged first.

pkg/proxy/volume.go Show resolved Hide resolved
@longhorn longhorn deleted a comment from mergify bot Dec 28, 2023
@longhorn longhorn deleted a comment from mergify bot Dec 28, 2023
@mergify Mergify
Copy link

mergify bot commented Dec 29, 2023

This pull request is now in conflicts. Could you fix it @FrankYang0529? 🙏

innobead
innobead previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge after the engine PR is merged and the dep is updated.

@FrankYang0529
feat(go.mod): update longhorn-engine
78148be 
Signed-off-by: PoAn Yang <poan.yang@suse.com>
@FrankYang0529
feat(proto): support snapshot max count and size
4cbee30 
Signed-off-by: PoAn Yang <poan.yang@suse.com>
@FrankYang0529
feat(proxy): support snapshot max count and size
9e8ece2 
Signed-off-by: PoAn Yang <poan.yang@suse.com>
@innobead innobead merged commit e09a1a8 into longhorn:master Jan 3, 2024
5 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-6563 branch January 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

Assignees

@FrankYang0529 FrankYang0529

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYang0529 @innobead