build Delete() for delete a node and all its descendant #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebx
commented
Dec 25, 2020
nested_set.go
Outdated
| if err != nil { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
ugly Gorm lock pattern. do you know how to lock a row without Find()?
calebx
commented
Dec 25, 2020
nested_set.go
Outdated
| @@ -140,6 +147,7 @@ func Create(db *gorm.DB, source, parent interface{}) error { | |||
| return err | |||
| } | |||
|
|
|||
| tx, _, _ := parseNode(db, source) | |||
There was a problem hiding this comment.
tx should be refreshed after UPDATE.
There was a problem hiding this comment.
@huacnlee @griffinqiu
any idea why?
Really confused me a lot.
calebx
commented
Dec 26, 2020
nested_set.go
Outdated
| @@ -197,7 +252,7 @@ func MoveTo(db *gorm.DB, node, to interface{}, direction MoveDirection) error { | |||
| return err | |||
| } | |||
|
|
|||
| tx = db.Table(targetNode.TableName) | |||
| tx = tx.Table(targetNode.TableName) | |||
There was a problem hiding this comment.
no db should be used after tx took after its scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.