-
Notifications
You must be signed in to change notification settings - Fork 122
input: Refactor Input, Picker as stateless mode. #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,945
−1,702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
added a commit
that referenced
this pull request
May 17, 2025
huacnlee
added a commit
that referenced
this pull request
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to improve
TextInput
andNumberInput
as a stateless mode by split aTextState
to keep the editing state.So we can easily control the UI style in render stage.
Break Changes
TextInput
separated to asInputState
(for Entity) andTextInput
for render.TextInput - Renamed
text
tovalue
,set_text
toset_value
and also addeddefault_value
method to set default value.ColorPicker
separated to asColorPickerState
andColorPicker
like input.Calendar
separated to asCalendarState
andCalendar
like input.Calendar
.DatePicker
separated to asDatePickerState
andDatePicker
like input.Slider
separated to asSliderState
andSlider
like input.disabled
state to slider.Dropdown
separated to asDropdownState
andDropdown
.