* Applied best practices for sorted list & diff callback

longbkiter07 · Apr 24, 2017 · 65fe2d3 · 65fe2d3
1 parent 37cea4e
commit 65fe2d3
Show file tree

Hide file tree

Showing 10 changed files with 963 additions and 683 deletions.
diff --git a/app/src/main/java/com/silong/snappyrecycleradapter/RecyclerViewActivity.java b/app/src/main/java/com/silong/snappyrecycleradapter/RecyclerViewActivity.java
@@ -142,7 +142,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
           mSyncAdapter.remove((int) (Math.random() * mSyncAdapter.getItemCount() - 1));
         } else {
           mRxUserRecyclerViewAdapter.getObservableAdapterManager()
-              .removeAt((int) (Math.random() * mRxUserRecyclerViewAdapter.getItemCount() - 1))
+              .removeItemAt((int) (Math.random() * mRxUserRecyclerViewAdapter.getItemCount() - 1))
               .subscribe();
         }
         break;

diff --git a/app/src/main/java/com/silong/snappyrecycleradapter/adapter/RxUserRecyclerViewAdapter.java b/app/src/main/java/com/silong/snappyrecycleradapter/adapter/RxUserRecyclerViewAdapter.java
@@ -60,6 +60,6 @@ public ItemViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
 
   @Override
   public void onBindViewHolder(ItemViewHolder holder, int position) {
-    holder.bind(mUserRxSortedList.getItemAt(position));
+    holder.bind(mUserRxSortedList.get(position));
   }
 }
diff --git a/app/src/main/java/com/silong/snappyrecycleradapter/model/DataFactory.java b/app/src/main/java/com/silong/snappyrecycleradapter/model/DataFactory.java
@@ -12,7 +12,7 @@
  */
 public class DataFactory {
 
-  public static final int CHUNK = 10000;
+  public static final int CHUNK = 10;
 
   private DataFactory() {