Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgres errors #80

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: postgres errors #80

merged 3 commits into from
Jan 31, 2024

Commits on Jan 30, 2024

  1. fix: postgres errors

    Having tried to implement meilisync on a postgres database I encountered some errors
    
    - `meilisync check` did not work because `RealDictCursor` was used as `cursor_factory` and `get_count` used integer indexing, which  `RealDictCursor` does not support
    
        - I have made my own custom Row and Cursor types that support key indexing and integer indexing
    
    - When deleting something from the database `columntypes` is not included in the payload. `.get` is used to fetch `columntypes` where the length of it is then computed, but `.get` is used without a default, so when it is not included, it would call `len` of `None` which gives an error
    
        - Added an empty list as default for the various `column` field in the payload
    
    - I am not sure if this is an error, but in the way I want to use meilisync it is. When setting fields for an index in the `config.yml` file, it updates the documents of the index with all the fields for the affected row. This makes search results inconsistent, and could potentially reveal information to the user it should not have.
    
        - Made it such that when giving fields in the config, it only updates the documents with those given fields. If no fields are given it will include all fields.
    lasseintree committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9d0a1c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. lint + add healthcheck

    lasseintree committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9db5a06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22dedef View commit details
    Browse the repository at this point in the history