Skip to content

Conversation

@leopittelli
Copy link

Imagine a carousel of images. If each item is Lazy loaded, the first items will be loaded and the ones at the right will wait until the user scrolls horizontally.

If the carousel is out of the initial viewport, the first images will also be loaded because they are "visible" on the container, but they are out of the screen. So, in this pull request I'm waiting the user scrolls to see the carousel in order to load the first images and then continue normally.

@leopittelli
Copy link
Author

@loktar00 how do you see this?

@Noahnrg
Copy link

Noahnrg commented Jul 1, 2020

@loktar00
I'm looking for a solution that fits the above problem.

Would it be possible to get this into the package?

@loktar00 loktar00 merged commit 00189c5 into loktar00:master Jul 1, 2020
@loktar00
Copy link
Owner

loktar00 commented Jul 1, 2020

@Noahnrg I have no idea how I didn't see this.... but it's been merged I'm not at my machine right now but I'll try and get the version update on NPM today.

@Noahnrg
Copy link

Noahnrg commented Jul 1, 2020

@loktar00 wow, fast response time!

Looking forward too it, thank you so much!

just to confirm, I'll be able to install the package via npm as react-lazy-load from https://www.npmjs.com/package/react-lazy-load with the new version number, and it'll have the updates... correct?

@loktar00
Copy link
Owner

loktar00 commented Jul 2, 2020

Correct, just updated it to 3.1.13.... kind of screwed up the vs really should be 3.1.0 oops :P but should pull down and work properly.

lol keep in mind the original PR for this was 3 years ago :/ I definitely let this package go as I was focusing on my day job a little too much for better or for worse I guess.

@Noahnrg
Copy link

Noahnrg commented Jul 2, 2020

Fantastic !! thanks so much, works like a charm :)
(using react 16.13.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants