Fix Issue #83: Issue with event firing on unmounted component. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this commit is gonna be merged with the base branch? |
|
I emailed the maintainer saying I would be happy to take over and he has never responded. |
|
I died. It is hacky but looks like some people need it so it's fine for a temp solution at the very least. Just been crazy busy with life/work :( haven't even made a pen in almost a year. |
|
Thanks for the PR by the way! |
|
@loktar00 could you release a new version on npm? 😄 |
|
@srn done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty terrible hack which resolves the problem I am seeing in issue #83. React considers this solution to be an anti-pattern. However, I don't see how to change the cleanup code to avoid the problem.