Youtubeclone #68
Youtubeclone #68
Conversation
Ambikadulal
commented
Feb 9, 2021
Ambikadulal
commented
lib/src/youtube_clone/HomePage.dart
Outdated
| child: ListTile( | ||
| leading: CircleAvatar( | ||
| backgroundImage: NetworkImage( | ||
| 'https://cdn.logo.com/hotlink-ok/logo-social.png'), |
There was a problem hiding this comment.
You can use links variables from assets.dart instead of hardcoding.
Use other images not logos..
README.md
Outdated
| @@ -138,7 +139,7 @@ The code for Springy Widget is taken and refactored from (https://github.com/mat | |||
| - Stateless & Stateful Widgets | |||
| - Custom widgets for list items, category items etc. | |||
|
|
|||
| <img height="480px" src="screenshots/grocery_home.png"> <img height="480px" src="screenshots/grocery_details.png"> <img height="480px" src="screenshots/grocery_cart.png"> <img height="480px" src="screenshots/grocery_wishlist.png"> <img height="480px" src="screenshots/grocery_options.png"> | |||
| <img height="480px" src="screenshots/youtube.jpg"> <img height="480px" src="screenshots/grocery_home.png"> <img height="480px" src="screenshots/grocery_details.png"> <img height="480px" src="screenshots/grocery_cart.png"> <img height="480px" src="screenshots/grocery_wishlist.png"> <img height="480px" src="screenshots/grocery_options.png"> | |||
There was a problem hiding this comment.
Wrong section keep this under miscellaneous, this is Grocery App UI kit
lib/core/presentation/routes.dart
Outdated
| @@ -76,6 +76,7 @@ import 'package:flutter_ui_challenges/src/pages/login/login7.dart'; | |||
| import 'package:flutter_ui_challenges/src/pages/login/login6.dart'; | |||
| import 'package:flutter_ui_challenges/src/pages/misc/loaders.dart'; | |||
| import 'package:flutter_ui_challenges/src/pages/grocery/ghome.dart'; | |||
| import 'package:flutter_ui_challenges/src/youtube_clone/HomePage.dart'; | |||
There was a problem hiding this comment.
You have created a new folder youtube_clone, this will break the code view, you will not be able to view the code in the app, as youtube_clone is not available in the pubspec, just put youtube_clone.dart inside misc folder instead of creating new folder.
Also HomePage.dart is not proper naming it should have been home_page.dart
lib/core/presentation/routes.dart
Outdated
| @@ -332,6 +333,7 @@ final List<dynamic> pages = [ | |||
| MenuItem( | |||
| title: "UI Kits (Clones)", | |||
| items: [ | |||
| SubMenuItem('Youtube Clone App', HomePage(), path: HomePage.path), | |||
There was a problem hiding this comment.
Name should be something like YoutubeClonePage() instead of HomePage(), its confusing.
There was a problem hiding this comment.
Keep it under misc section. UI kits clones are the sections for such UIs that have implemented multiple pages of an existing app or UI kit
