Skip to content

feat(console): update security page #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simeng-li
Copy link
Contributor

Summary

Update the security page

This PR includes the following updates

  1. Change the tab order of the security page.
image
  1. Update the sentinel unlock modal form
  • Always enabled the unlock submit button
  • Display form error if the identifier's input value is empty
image

Testing

test locally

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Apr 15, 2025

COMPARE TO master

Total Size Diff 📈 +1.41 KB

Diff by File
Name Diff
packages/console/src/pages/Security/General/SentinelUnlockModal/index.tsx 📈 +184 Bytes
packages/console/src/pages/Security/index.tsx 0 Bytes
packages/phrases/src/locales/ar/translation/admin-console/security.ts 📈 +89 Bytes
packages/phrases/src/locales/de/translation/admin-console/security.ts 📈 +81 Bytes
packages/phrases/src/locales/en/translation/admin-console/security.ts 📈 +70 Bytes
packages/phrases/src/locales/es/translation/admin-console/security.ts 📈 +78 Bytes
packages/phrases/src/locales/fr/translation/admin-console/security.ts 📈 +73 Bytes
packages/phrases/src/locales/it/translation/admin-console/security.ts 📈 +68 Bytes
packages/phrases/src/locales/ja/translation/admin-console/security.ts 📈 +94 Bytes
packages/phrases/src/locales/ko/translation/admin-console/security.ts 📈 +79 Bytes
packages/phrases/src/locales/pl-pl/translation/admin-console/security.ts 📈 +85 Bytes
packages/phrases/src/locales/pt-br/translation/admin-console/security.ts 📈 +79 Bytes
packages/phrases/src/locales/pt-pt/translation/admin-console/security.ts 📈 +79 Bytes
packages/phrases/src/locales/ru/translation/admin-console/security.ts 📈 +128 Bytes
packages/phrases/src/locales/tr-tr/translation/admin-console/security.ts 📈 +64 Bytes
packages/phrases/src/locales/zh-cn/translation/admin-console/security.ts 📈 +64 Bytes
packages/phrases/src/locales/zh-hk/translation/admin-console/security.ts 📈 +64 Bytes
packages/phrases/src/locales/zh-tw/translation/admin-console/security.ts 📈 +64 Bytes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Base automatically changed from simeng-log-11335-translation-of-sie-toast to master April 16, 2025 04:06
@github-actions github-actions bot added size/xl and removed size/s labels Apr 16, 2025
@simeng-li simeng-li force-pushed the simeng-log-11332-tab-order-password-policy-captcha-general branch from 792189b to 3f9c315 Compare April 16, 2025 04:07
@github-actions github-actions bot added size/s and removed size/xl labels Apr 16, 2025
@simeng-li simeng-li enabled auto-merge (squash) April 16, 2025 04:10
@simeng-li simeng-li merged commit 47d1b30 into master Apr 16, 2025
34 checks passed
@simeng-li simeng-li deleted the simeng-log-11332-tab-order-password-policy-captcha-general branch April 16, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants