Skip to content

feat(core, schemas): add API to clear sentinel activities #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

simeng-li
Copy link
Contributor

Summary

Add API to clear sentinel activities. This is useful for the admin to unblock users by a given list of identifiers.

Testing

test locally
integration tests added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the feature Cool stuff label Apr 11, 2025
@simeng-li simeng-li requested a review from Copilot April 11, 2025 08:24
Copy link

github-actions bot commented Apr 11, 2025

COMPARE TO master

Total Size Diff 📈 +8.51 KB

Diff by File
Name Diff
packages/core/src/queries/sentinel-activities.ts 📈 +984 Bytes
packages/core/src/routes/init.ts 📈 +170 Bytes
packages/core/src/routes/sentinel-activities.openapi.json 📈 +925 Bytes
packages/core/src/routes/sentinel-activities.ts 📈 +1.2 KB
packages/core/src/routes/swagger/utils/operation-id.ts 📈 +66 Bytes
packages/core/src/sentinel/basic-sentinel.ts 📈 +2 Bytes
packages/core/src/tenants/Queries.ts 📈 +152 Bytes
packages/integration-tests/src/tests/api/experience-api/basic-sentinel.test.ts 📈 +4.45 KB
packages/schemas/alterations/next-1744357867-add-sentinel-activities-hash-index.ts 📈 +507 Bytes
packages/schemas/tables/sentinel_activities.sql 📈 +123 Bytes

@simeng-li simeng-li requested review from a team April 11, 2025 08:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • packages/core/src/routes/sentinel-activities.openapi.json: Language not supported
  • packages/schemas/tables/sentinel_activities.sql: Language not supported
Comments suppressed due to low confidence (1)

packages/core/src/routes/init.ts:115

  • Review whether gating the sentinel activities route with a development flag is intended, as this might prevent necessary admin functionality in production.
if (EnvSet.values.isDevFeaturesEnabled) {

fix swagger json generation
@simeng-li simeng-li force-pushed the simeng-log-11273-core-add-unblock-identifier-api branch from 13c35a6 to e85961b Compare April 14, 2025 02:00
@simeng-li simeng-li requested review from a team and charIeszhao and removed request for a team April 14, 2025 02:09
@simeng-li simeng-li merged commit ddeec79 into master Apr 14, 2025
37 checks passed
@simeng-li simeng-li deleted the simeng-log-11273-core-add-unblock-identifier-api branch April 14, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants