-
-
Notifications
You must be signed in to change notification settings - Fork 517
fix(connector): support string typed boolean ID token claims for OIDC connector #7276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): support string typed boolean ID token claims for OIDC connector #7276
Conversation
COMPARE TO
|
Name | Diff |
---|---|
.changeset/selfish-zoos-worry.md | 📈 +611 Bytes |
packages/connectors/connector-oidc/src/constant.ts | 📈 +521 Bytes |
packages/connectors/connector-oidc/src/index.ts | 📈 +165 Bytes |
packages/connectors/connector-oidc/src/types.test.ts | 📈 +2.88 KB |
packages/connectors/connector-oidc/src/types.ts | 📈 +640 Bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/connectors/connector-oidc/src/types.ts:34
- [nitpick] Consider shortening the name 'idTokenProfileStandardClaimsGuardAcceptingStringTypedBooleanClaims' for improved readability. For instance, a simpler name like 'idTokenClaimsGuardWithStringBooleans' might enhance clarity.
// Extend `idTokenProfileStandardClaimsGuard` by accepting string-typed boolean claims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on changeset
Summary
Add an optional
acceptStringTypedBooleanClaims
configuration toOidcConnectorConfig
, with default valuefalse
.For standard OIDC protocol, some claims such as
email_verified
andphone_verified
are boolean-typed, but some providers may return them as string-typed. Enabling this option will convert string-typed boolean claims to boolean-typed, which provides better compatibility.By enabling this configuration, the connector will accept string-typed boolean ID token claims, such as
email_verified
andphone_verified
.Testing
Covered by unit tests.
Checklist
.changeset