feat(console,schemas,core): add sentinel policy settings page #7273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeng-li
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/hooks/use-console-routes/routes/security.tsx | 📈 +103 Bytes |
| packages/console/src/pages/Security/General/GeneralForm/index.module.scss | 📈 +216 Bytes |
| packages/console/src/pages/Security/General/GeneralForm/index.tsx | 📈 +4.71 KB |
| packages/console/src/pages/Security/General/index.module.scss | 📈 +99 Bytes |
| packages/console/src/pages/Security/General/index.tsx | 📈 +745 Bytes |
| packages/console/src/pages/Security/General/use-data-fetch.ts | 📈 +1.2 KB |
| packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.tsx | 📈 +1 Bytes |
| packages/console/src/pages/Security/PasswordPolicy/index.module.scss | 📈 +425 Bytes |
| packages/console/src/pages/Security/PasswordPolicy/index.tsx | 📈 +157 Bytes |
| packages/console/src/pages/Security/index.tsx | 📈 +361 Bytes |
| packages/console/src/pages/Security/types.ts | 📈 +23 Bytes |
| packages/core/src/sentinel/basic-sentinel.ts | 📈 +201 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/security.ts | 📈 +798 Bytes |
| packages/schemas/src/consts/index.ts | 📈 +31 Bytes |
| packages/schemas/src/consts/sentinel.ts | 📈 +296 Bytes |
There was a problem hiding this comment.
Copilot reviewed 12 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (3)
- packages/console/src/pages/Security/General/GeneralForm/index.module.scss: Language not supported
- packages/console/src/pages/Security/General/index.module.scss: Language not supported
- packages/console/src/pages/Security/PasswordPolicy/index.module.scss: Language not supported
Comments suppressed due to low confidence (1)
packages/phrases/src/locales/en/translation/admin-console/security.ts:33
- The description contains a grammatical error; consider changing 'trigger' to 'triggers' to improve clarity.
description: 'Limit consecutive failed sign-ins per identifier. Exceeding this limit trigger a temporary block.',
wangsijie
approved these changes
Apr 11, 2025
simeng-li
force-pushed
the
simeng-log-11227-core-update-experience-to-read-sentinel-settings-from-sie
branch
from
cc74b15 to
a527be4
Compare
simeng-li
force-pushed
the
simeng-log-11226-console-add-sentinel-settings-in-security-page
branch
from
8266d9e to
2352e32
Compare
Base automatically changed from
simeng-log-11227-core-update-experience-to-read-sentinel-settings-from-sie
to
master
April 11, 2025 03:24
add sentinel policy settings page
simeng-li
force-pushed
the
simeng-log-11226-console-add-sentinel-settings-in-security-page
branch
from
2352e32 to
6d54e48
Compare
simeng-li
deleted the
simeng-log-11226-console-add-sentinel-settings-in-security-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add sentinel policy settings page to console.
Testing
test locally
Checklist
.changeset