Skip to content

refactor: use with to replace assert #7272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

refactor: use with to replace assert #7272

merged 4 commits into from
Apr 10, 2025

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Apr 10, 2025

Summary

assert is deprecated and will be removed soon. this pull replace it with the updated syntax.

  • update node requirement to ^20.19.0 since 20.9 doesn't support with
  • upgrade prettier to support the new syntax
  • explicitly specific node version in workflows

the "real" code change only includes:

image

Testing

ci

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the enhancement Make it better label Apr 10, 2025
Copy link

github-actions bot commented Apr 10, 2025

COMPARE TO master

Total Size Diff 📈 +2.77 KB

Diff by File
Name Diff
.changeset/rich-buckets-yell.md 📈 +2.2 KB
.github/workflows/changesets.yml 📈 +33 Bytes
.github/workflows/commitlint.yml 📈 +33 Bytes
.github/workflows/main.yml 📈 +351 Bytes
.github/workflows/master-codecov-report.yml 📈 +33 Bytes
.github/workflows/release.yml 📈 +66 Bytes
.github/workflows/upload-annotations.yml 📈 +33 Bytes
package.json 📈 +1 Bytes
packages/app-insights/package.json 📈 +1 Bytes
packages/cli/package.json 📈 +1 Bytes
packages/cli/src/connector/loader.ts 📈 +2 Bytes
packages/connectors/connector-alipay-native/package.json 📈 +1 Bytes
packages/connectors/connector-alipay-web/package.json 📈 +1 Bytes
packages/connectors/connector-aliyun-dm/package.json 📈 +1 Bytes
packages/connectors/connector-aliyun-sms/package.json 📈 +1 Bytes
packages/connectors/connector-amazon/package.json 📈 +1 Bytes
packages/connectors/connector-apple/package.json 📈 +1 Bytes
packages/connectors/connector-aws-ses/package.json 📈 +1 Bytes
packages/connectors/connector-azuread/package.json 📈 +1 Bytes
packages/connectors/connector-dingtalk-web/package.json 📈 +1 Bytes
packages/connectors/connector-discord/package.json 📈 +1 Bytes
packages/connectors/connector-facebook/package.json 📈 +1 Bytes
packages/connectors/connector-feishu-web/package.json 📈 +1 Bytes
packages/connectors/connector-gatewayapi-sms/package.json 📈 +1 Bytes
packages/connectors/connector-github/package.json 📈 +1 Bytes
packages/connectors/connector-gitlab/package.json 📈 +1 Bytes
packages/connectors/connector-google/package.json 📈 +1 Bytes
packages/connectors/connector-http-email/package.json 📈 +1 Bytes
packages/connectors/connector-huggingface/package.json 📈 +1 Bytes
packages/connectors/connector-kakao/package.json 📈 +1 Bytes
packages/connectors/connector-kook/package.json 📈 +1 Bytes
packages/connectors/connector-line/package.json 📈 +1 Bytes
packages/connectors/connector-linkedin/package.json 📈 +1 Bytes
packages/connectors/connector-logto-email/package.json 📈 +1 Bytes
packages/connectors/connector-logto-sms/package.json 📈 +1 Bytes
packages/connectors/connector-logto-social-demo/package.json 📈 +1 Bytes
packages/connectors/connector-mailgun/package.json 📈 +1 Bytes
packages/connectors/connector-mock-email-alternative/package.json 📈 +1 Bytes
packages/connectors/connector-mock-email/package.json 📈 +1 Bytes
packages/connectors/connector-mock-sms/package.json 📈 +1 Bytes
packages/connectors/connector-mock-social/package.json 📈 +1 Bytes
packages/connectors/connector-naver/package.json 📈 +1 Bytes
packages/connectors/connector-oauth2/package.json 📈 +1 Bytes
packages/connectors/connector-oidc/package.json 📈 +1 Bytes
packages/connectors/connector-patreon/package.json 📈 +1 Bytes
packages/connectors/connector-postmark/package.json 📈 +1 Bytes
packages/connectors/connector-saml/package.json 📈 +1 Bytes
packages/connectors/connector-sendgrid-email/package.json 📈 +1 Bytes
packages/connectors/connector-slack/package.json 📈 +1 Bytes
packages/connectors/connector-smsaero/package.json 📈 +1 Bytes
packages/connectors/connector-smtp/package.json 📈 +1 Bytes
packages/connectors/connector-tencent-sms/package.json 📈 +1 Bytes
packages/connectors/connector-twilio-sms/package.json 📈 +1 Bytes
packages/connectors/connector-vonage-sms/package.json 📈 +1 Bytes
packages/connectors/connector-wechat-native/package.json 📈 +1 Bytes
packages/connectors/connector-wechat-web/package.json 📈 +1 Bytes
packages/connectors/connector-wecom/package.json 📈 +1 Bytes
packages/connectors/connector-x/package.json 📈 +1 Bytes
packages/connectors/connector-xiaomi/package.json 📈 +1 Bytes
packages/connectors/connector-yunpian-sms/package.json 📈 +1 Bytes
packages/connectors/templates/package.json 📈 +1 Bytes
packages/console/package.json 📈 +1 Bytes
packages/console/src/hooks/use-search-parameters-watcher.ts 📈 +18 Bytes
packages/console/src/pages/Connectors/Guide/index.tsx 📈 +12 Bytes
packages/console/src/pages/EnterpriseSsoDetails/Connection/SamlMetadataForm/index.tsx 📈 +4 Bytes
packages/console/src/pages/Roles/components/AssignedEntities/index.tsx 📈 +4 Bytes
packages/console/src/pages/TenantSettings/Subscription/SwitchPlanActionBar/index.tsx 📈 +4 Bytes
packages/console/src/utils/connector-form.ts 📈 +2 Bytes
packages/core/package.json 📈 +1 Bytes
packages/core/src/include.d/oidc-provider/lib-keep/helpers/weak_cache.d.ts 📈 +12 Bytes
packages/core/src/libraries/saml-application/saml-applications.ts 📈 +6 Bytes
packages/core/src/middleware/koa-guard.ts 📈 +2 Bytes
packages/core/src/oidc/extra-token-claims.ts 📈 +4 Bytes
packages/core/src/oidc/resource.ts 📈 +10 Bytes
packages/core/src/routes/applications/application-sign-in-experience.ts 📈 +16 Bytes
packages/core/src/routes/experience/classes/mfa.ts 📈 +6 Bytes
packages/core/src/routes/experience/verification-routes/web-authn-verification.ts 📈 +8 Bytes
packages/core/src/routes/interaction/additional.ts 📈 +10 Bytes
packages/core/src/routes/interaction/verifications/profile-verification.ts 📈 +4 Bytes
packages/core/src/utils/RelationQueries.ts 📈 +4 Bytes
packages/create/package.json 📈 +1 Bytes
packages/demo-app/package.json 📈 +1 Bytes
packages/elements/package.json 📈 +1 Bytes
packages/experience/package.json 📈 +1 Bytes
packages/experience/src/hooks/use-connectors.ts 📈 +4 Bytes
packages/experience/src/types/index.ts 📈 +6 Bytes
packages/integration-tests/package.json 📈 +1 Bytes
packages/integration-tests/src/tests/api/sso-connectors/sso-connector-idp-initiated-auth-config.test.ts 📈 +20 Bytes
packages/integration-tests/src/tests/console/connectors/helpers.ts 📈 +4 Bytes
packages/phrases-experience/package.json 📈 +1 Bytes
packages/phrases/package.json 📈 +1 Bytes
packages/schemas/package.json 📈 +1 Bytes
packages/shared/package.json 📈 +1 Bytes
packages/toolkit/connector-kit/package.json 📈 +1 Bytes
packages/toolkit/core-kit/package.json 📈 +1 Bytes
packages/toolkit/language-kit/package.json 📈 +1 Bytes
packages/translate/package.json 📈 +1 Bytes
packages/translate/src/sync-keys/utils.ts 📈 +4 Bytes
packages/tunnel/package.json 📈 +1 Bytes
pnpm-lock.yaml 0 Bytes

@github-actions github-actions bot added size/l and removed size/m labels Apr 10, 2025
@gao-sun gao-sun marked this pull request as ready for review April 10, 2025 04:19
@gao-sun gao-sun enabled auto-merge (squash) April 10, 2025 04:19
@gao-sun gao-sun merged commit a172ddb into master Apr 10, 2025
40 of 44 checks passed
@gao-sun gao-sun deleted the gao-use-with branch April 10, 2025 05:32
@charIeszhao charIeszhao mentioned this pull request Apr 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/l
Development

Successfully merging this pull request may close these issues.

3 participants