-
-
Notifications
You must be signed in to change notification settings - Fork 517
refactor(console): move password policy to security page #7259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simeng-li
merged 2 commits into
master
from
simeng-log-11224-console-move-password-policy-settings-to-security
Apr 10, 2025
Merged
refactor(console): move password policy to security page #7259
simeng-li
merged 2 commits into
master
from
simeng-log-11224-console-move-password-policy-settings-to-security
Apr 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move password policy to security page
COMPARE TO
|
Name | Diff |
---|---|
packages/console/src/hooks/use-console-routes/routes/security.tsx | 📈 +117 Bytes |
packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.module.scss | 📈 +521 Bytes |
packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.tsx | 📈 +1.23 KB |
packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.module.scss | 📈 +457 Bytes |
packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.tsx | 📈 +7.06 KB |
packages/console/src/pages/Security/PasswordPolicy/index.module.scss | 📈 +524 Bytes |
packages/console/src/pages/Security/PasswordPolicy/index.tsx | 📈 +944 Bytes |
packages/console/src/pages/Security/PasswordPolicy/use-password-policy.ts | 📈 +1.91 KB |
packages/console/src/pages/Security/index.module.scss | 📈 +43 Bytes |
packages/console/src/pages/Security/index.tsx | 📈 +587 Bytes |
packages/console/src/pages/SignInExperience/PageContent/index.tsx | 📈 +163 Bytes |
packages/integration-tests/src/tests/console/security/password-policy.test.ts | 📈 +2.55 KB |
packages/integration-tests/src/tests/console/sign-in-experience/password-policy.test.ts | 📈 +79 Bytes |
packages/integration-tests/src/ui-helpers/expect-console.ts | 📈 +131 Bytes |
packages/phrases/src/locales/en/translation/admin-console/security.ts | 📈 +1.47 KB |
charIeszhao
reviewed
Apr 9, 2025
charIeszhao
approved these changes
Apr 9, 2025
Please check CI |
add security page integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 15 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.module.scss: Language not supported
- packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.module.scss: Language not supported
- packages/console/src/pages/Security/PasswordPolicy/index.module.scss: Language not supported
- packages/console/src/pages/Security/index.module.scss: Language not supported
Comments suppressed due to low confidence (2)
packages/console/src/pages/SignInExperience/PageContent/index.tsx:135
- Since the password policy has been migrated to the security page per the PR title, consider removing the password policy tab from the sign-in experience page to avoid redundancy.
{!isDevFeaturesEnabled && (<PageTab href="../password-policy">{t('sign_in_exp.tabs.password_policy')}</PageTab>)}
packages/console/src/pages/SignInExperience/PageContent/index.tsx:146
- With the migration of password policy to the security page, rendering the PasswordPolicy component in the sign-in experience page might be unnecessary and could lead to duplicate functionality.
{!isDevFeaturesEnabled && (<PasswordPolicy isActive={tab === SignInExperienceTab.PasswordPolicy} />)}
packages/integration-tests/src/tests/console/sign-in-experience/password-policy.test.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the password policy settings page under the security section.
Testing
Test locally

Checklist
.changeset