Skip to content

refactor(console): move password policy to security page #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Apr 9, 2025

Summary

Migrate the password policy settings page under the security section.

Testing

Test locally
image

image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

move password policy to security page
@simeng-li simeng-li requested review from a team April 9, 2025 08:41
Copy link

github-actions bot commented Apr 9, 2025

COMPARE TO master

Total Size Diff ⚠️ 📈 +17.69 KB

Diff by File
Name Diff
packages/console/src/hooks/use-console-routes/routes/security.tsx 📈 +117 Bytes
packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.module.scss 📈 +521 Bytes
packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.tsx 📈 +1.23 KB
packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.module.scss 📈 +457 Bytes
packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.tsx 📈 +7.06 KB
packages/console/src/pages/Security/PasswordPolicy/index.module.scss 📈 +524 Bytes
packages/console/src/pages/Security/PasswordPolicy/index.tsx 📈 +944 Bytes
packages/console/src/pages/Security/PasswordPolicy/use-password-policy.ts 📈 +1.91 KB
packages/console/src/pages/Security/index.module.scss 📈 +43 Bytes
packages/console/src/pages/Security/index.tsx 📈 +587 Bytes
packages/console/src/pages/SignInExperience/PageContent/index.tsx 📈 +163 Bytes
packages/integration-tests/src/tests/console/security/password-policy.test.ts 📈 +2.55 KB
packages/integration-tests/src/tests/console/sign-in-experience/password-policy.test.ts 📈 +79 Bytes
packages/integration-tests/src/ui-helpers/expect-console.ts 📈 +131 Bytes
packages/phrases/src/locales/en/translation/admin-console/security.ts 📈 +1.47 KB

@charIeszhao
Copy link
Member

Please check CI

add security page integration tests
@github-actions github-actions bot added size/xl and removed size/l labels Apr 10, 2025
@simeng-li simeng-li enabled auto-merge (squash) April 10, 2025 03:28
@simeng-li simeng-li requested a review from Copilot April 10, 2025 03:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • packages/console/src/pages/Security/PasswordPolicy/PasswordOption/index.module.scss: Language not supported
  • packages/console/src/pages/Security/PasswordPolicy/PasswordPolicyForm/index.module.scss: Language not supported
  • packages/console/src/pages/Security/PasswordPolicy/index.module.scss: Language not supported
  • packages/console/src/pages/Security/index.module.scss: Language not supported
Comments suppressed due to low confidence (2)

packages/console/src/pages/SignInExperience/PageContent/index.tsx:135

  • Since the password policy has been migrated to the security page per the PR title, consider removing the password policy tab from the sign-in experience page to avoid redundancy.
{!isDevFeaturesEnabled && (<PageTab href="../password-policy">{t('sign_in_exp.tabs.password_policy')}</PageTab>)}

packages/console/src/pages/SignInExperience/PageContent/index.tsx:146

  • With the migration of password policy to the security page, rendering the PasswordPolicy component in the sign-in experience page might be unnecessary and could lead to duplicate functionality.
{!isDevFeaturesEnabled && (<PasswordPolicy isActive={tab === SignInExperienceTab.PasswordPolicy} />)}

@simeng-li simeng-li merged commit 7760f74 into master Apr 10, 2025
34 checks passed
@simeng-li simeng-li deleted the simeng-log-11224-console-move-password-policy-settings-to-security branch April 10, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants