Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): rename account prefix to my-account #6821

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

wangsijie
Copy link
Contributor

@wangsijie wangsijie commented Nov 19, 2024

Summary

Per discussion, rename /account to /my-account.

This PR also removes duplicated integration tests caused by wrong rebase.

Testing

Existing tests.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Nov 19, 2024

COMPARE TO master

Total Size Diff 📉 -7.4 KB

Diff by File
Name Diff
packages/core/src/routes/account/constants.ts 📉 -3 Bytes
packages/core/src/routes/account/index.openapi.json 📉 -24 Bytes
packages/core/src/routes/swagger/utils/operation-id.ts 📉 -144 Bytes
packages/integration-tests/src/api/my-account.ts 📉 -2.5 KB
packages/integration-tests/src/api/profile.ts 📉 -2.46 KB
packages/integration-tests/src/tests/api/account/account-center-reject.test.ts 📉 -6 Bytes
packages/integration-tests/src/tests/api/account/email-and-phone.test.ts 📉 -7.65 KB
packages/integration-tests/src/tests/api/account/index.test.ts 📉 -27 Bytes
packages/integration-tests/src/tests/api/account/social.test.ts 📉 -12 Bytes

Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from wangsijie-account-api-feature-guard to master November 19, 2024 03:54
@wangsijie wangsijie enabled auto-merge (squash) November 19, 2024 04:21
@wangsijie wangsijie force-pushed the wangsijie-my-account branch 4 times, most recently from d83a763 to 7bc8d2a Compare November 19, 2024 06:51
@wangsijie wangsijie merged commit 9795412 into master Nov 19, 2024
34 checks passed
@wangsijie wangsijie deleted the wangsijie-my-account branch November 19, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/l
Development

Successfully merging this pull request may close these issues.

2 participants